Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

Update thing-types.xml #3

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Update thing-types.xml #3

merged 1 commit into from
Jun 16, 2020

Conversation

crimsonclyde
Copy link
Contributor

Added missing effects

PACIFICA, 101
CANDLE_MULTI, 102
SOLID_GLITTER, 103
SUNRISE, 104
PHASED, 105
TWINKLEUP, 106
NOISEPA, 107
SINEWAVE, 108
PHASEDNOISE, 109
FLOW, 110

according to Efffect Index (FX) from https://github.com/Skinah/wled/blob/master/target/classes/ESH-INF/thing/thing-types.xml

Added: 
PACIFICA               101
CANDLE_MULTI           102
SOLID_GLITTER          103
SUNRISE                104
PHASED                 105
TWINKLEUP              106
NOISEPAL               107
SINEWAVE               108
PHASEDNOISE            109
FLOW                 110
Copy link
Owner

@Skinah Skinah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Adding the changes and will make a new build next week with them. It is possible the fetch a list of FX from the device and automate this so every release has a correct list, this is on the to do list when I am bored.

@Skinah Skinah merged commit b7e74dd into Skinah:master Jun 16, 2020
@crimsonclyde
Copy link
Contributor Author

Hi Skinah,

very welcome. I did only a few lines so the one that should earn kudos is you :)

If there is time I can help here and there, but I am not the biggest one when it comes down to Java ;) but totally agree that fetching the FX elements is the way to go.

One question, is there a reason why the .jar files are not located directly on GitHub and no mention where to find them pre-compiled?

But all in all awesome ;) thx m8 cheers clyde

@crimsonclyde crimsonclyde deleted the patch-1 branch June 17, 2020 08:12
@Skinah
Copy link
Owner

Skinah commented Jun 17, 2020

Yes that would be a better place to
Put them but when I tried to make a release in the past all GitHub did was to store the source and not the precompiled jar. Just did not bother to figure out how to upload a jar since then. Will add a link to the readme if I can’t work out using GitHub for a jar.

@crimsonclyde
Copy link
Contributor Author

https://stackoverflow.com/questions/16547301/best-way-to-upload-deploy-jar-files-in-github

Maybe it helps you.
I think you haven't had the time to compile a new .jar file. Should I try to assist?

@Skinah
Copy link
Owner

Skinah commented Jul 6, 2020

Sorry I will look at this in the next few days. BTW the file the changes needed to go into is https://github.com/Skinah/wled/blob/master/src/main/resources/ESH-INF/thing/thing-types.xml as the target folder gets deleted when you build it...

To build you type in mvn clean compile package as that skips the disk checks if the usual mvn clean install comes up with an error.

@ghost
Copy link

ghost commented Jul 6, 2020

Hi this is the complete list of effects from wled code.
#define FX_MODE_STATIC 0
#define FX_MODE_BLINK 1
#define FX_MODE_BREATH 2
#define FX_MODE_COLOR_WIPE 3
#define FX_MODE_COLOR_WIPE_RANDOM 4
#define FX_MODE_RANDOM_COLOR 5
#define FX_MODE_COLOR_SWEEP 6
#define FX_MODE_DYNAMIC 7
#define FX_MODE_RAINBOW 8
#define FX_MODE_RAINBOW_CYCLE 9
#define FX_MODE_SCAN 10
#define FX_MODE_DUAL_SCAN 11
#define FX_MODE_FADE 12
#define FX_MODE_THEATER_CHASE 13
#define FX_MODE_THEATER_CHASE_RAINBOW 14
#define FX_MODE_RUNNING_LIGHTS 15
#define FX_MODE_SAW 16
#define FX_MODE_TWINKLE 17
#define FX_MODE_DISSOLVE 18
#define FX_MODE_DISSOLVE_RANDOM 19
#define FX_MODE_SPARKLE 20
#define FX_MODE_FLASH_SPARKLE 21
#define FX_MODE_HYPER_SPARKLE 22
#define FX_MODE_STROBE 23
#define FX_MODE_STROBE_RAINBOW 24
#define FX_MODE_MULTI_STROBE 25
#define FX_MODE_BLINK_RAINBOW 26
#define FX_MODE_ANDROID 27
#define FX_MODE_CHASE_COLOR 28
#define FX_MODE_CHASE_RANDOM 29
#define FX_MODE_CHASE_RAINBOW 30
#define FX_MODE_CHASE_FLASH 31
#define FX_MODE_CHASE_FLASH_RANDOM 32
#define FX_MODE_CHASE_RAINBOW_WHITE 33
#define FX_MODE_COLORFUL 34
#define FX_MODE_TRAFFIC_LIGHT 35
#define FX_MODE_COLOR_SWEEP_RANDOM 36
#define FX_MODE_RUNNING_COLOR 37
#define FX_MODE_RUNNING_RED_BLUE 38
#define FX_MODE_RUNNING_RANDOM 39
#define FX_MODE_LARSON_SCANNER 40
#define FX_MODE_COMET 41
#define FX_MODE_FIREWORKS 42
#define FX_MODE_RAIN 43
#define FX_MODE_MERRY_CHRISTMAS 44
#define FX_MODE_FIRE_FLICKER 45
#define FX_MODE_GRADIENT 46
#define FX_MODE_LOADING 47
#define FX_MODE_POLICE 48
#define FX_MODE_POLICE_ALL 49
#define FX_MODE_TWO_DOTS 50
#define FX_MODE_TWO_AREAS 51
#define FX_MODE_CIRCUS_COMBUSTUS 52
#define FX_MODE_HALLOWEEN 53
#define FX_MODE_TRICOLOR_CHASE 54
#define FX_MODE_TRICOLOR_WIPE 55
#define FX_MODE_TRICOLOR_FADE 56
#define FX_MODE_LIGHTNING 57
#define FX_MODE_ICU 58
#define FX_MODE_MULTI_COMET 59
#define FX_MODE_DUAL_LARSON_SCANNER 60
#define FX_MODE_RANDOM_CHASE 61
#define FX_MODE_OSCILLATE 62
#define FX_MODE_PRIDE_2015 63
#define FX_MODE_JUGGLE 64
#define FX_MODE_PALETTE 65
#define FX_MODE_FIRE_2012 66
#define FX_MODE_COLORWAVES 67
#define FX_MODE_BPM 68
#define FX_MODE_FILLNOISE8 69
#define FX_MODE_NOISE16_1 70
#define FX_MODE_NOISE16_2 71
#define FX_MODE_NOISE16_3 72
#define FX_MODE_NOISE16_4 73
#define FX_MODE_COLORTWINKLE 74
#define FX_MODE_LAKE 75
#define FX_MODE_METEOR 76
#define FX_MODE_METEOR_SMOOTH 77
#define FX_MODE_RAILWAY 78
#define FX_MODE_RIPPLE 79
#define FX_MODE_TWINKLEFOX 80
#define FX_MODE_TWINKLECAT 81
#define FX_MODE_HALLOWEEN_EYES 82
#define FX_MODE_STATIC_PATTERN 83
#define FX_MODE_TRI_STATIC_PATTERN 84
#define FX_MODE_SPOTS 85
#define FX_MODE_SPOTS_FADE 86
#define FX_MODE_GLITTER 87
#define FX_MODE_CANDLE 88
#define FX_MODE_STARBURST 89
#define FX_MODE_EXPLODING_FIREWORKS 90
#define FX_MODE_BOUNCINGBALLS 91
#define FX_MODE_SINELON 92
#define FX_MODE_SINELON_DUAL 93
#define FX_MODE_SINELON_RAINBOW 94
#define FX_MODE_POPCORN 95
#define FX_MODE_DRIP 96
#define FX_MODE_PLASMA 97
#define FX_MODE_PERCENT 98
#define FX_MODE_RIPPLE_RAINBOW 99
#define FX_MODE_HEARTBEAT 100
#define FX_MODE_PACIFICA 101
#define FX_MODE_CANDLE_MULTI 102
#define FX_MODE_SOLID_GLITTER 103
#define FX_MODE_SUNRISE 104
#define FX_MODE_PHASED 105
#define FX_MODE_TWINKLEUP 106
#define FX_MODE_NOISEPAL 107
#define FX_MODE_SINEWAVE 108
#define FX_MODE_PHASEDNOISE 109
#define FX_MODE_FLOW 110
#define FX_MODE_CHUNCHUN 111

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants