[std] Support cwd in Posix.Popen.
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables setting the child process' cwd when calling
`Posix.Popen::create{}`/`System.popen{}`.
|
LGTM |
jberdine
reviewed
May 16, 2024
Comment on lines
+281
to
+287
| // NOTE: Since `posix_spawn()` does not provide a way for changing the | ||
| // working directory of the child process, we rely on GNU env. | ||
| cwd match { | ||
| | Some(path) -> !args = Array["env", "-C", path].concat(args) | ||
| | None() -> void | ||
| }; | ||
|
|
There was a problem hiding this comment.
We can't use posix_spawn_file_actions_addchdir I guess? This makes me think it would be better to give up on posix_spawn and just use (v)fork/exec so that we can chdir and whatever else is needed in the child between fork and exec. Wrapping the whole thing in env is just a heavy-weight version of that right?
There was a problem hiding this comment.
Yeah at this stage posix_spawn_file_actions_addchdir_np is a non-standard extension. I agree that posix_spawn is a bit too limiting for our use, and that we should move to (v)fork/exec. I'll open an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables setting the child process' cwd when calling
Posix.Popen::create{}/System.popen{}.