Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM_5ePack_UA - WarWiz.user missing update #676

Closed
TheEnthusiast opened this issue Jun 7, 2017 · 7 comments
Closed

COM_5ePack_UA - WarWiz.user missing update #676

TheEnthusiast opened this issue Jun 7, 2017 · 7 comments

Comments

@TheEnthusiast
Copy link
Collaborator

Hello,

Somehow, the file with the new warlock invocations has reverted pull 592, which implemented 5 invocations I forgot to add on the first file version. Can someone readd these missing invocations.

I'm currently without my computer to do it.

thanks.

@DarkHayZe
Copy link
Collaborator

Whomever does this, download the updated one from Github, I updated it last night for the new updates from the Warlock from the June 5th UA.

@LordMorin
Copy link
Collaborator

I know I did a bug fix on the warlock invocations. I corrected scripting errors. I zipped the .user file and uploaded (it was working at that time for me).

I don't know if it was my file that reverted though.

It should still be in the archived bug fixes.

@Sklore
Copy link
Owner

Sklore commented Jun 7, 2017

aff7b29

@LordMorin
Copy link
Collaborator

LordMorin commented Jun 8, 2017

Could someone who has COM_5ePack_UA - WarWiz.user installed create a Lore Master wizard and tell me if the Lore Mastery Class ability is actually working. I just discovered that mine is not granting Double Proficiency to Arcana, History, Nature and Religion.

I just need to know if its just me of if others have the same problem now.

@ghost
Copy link

ghost commented Jun 24, 2017

I'm getting the double proficiency bonus from Lore Mastery added to skills where I shouldn't be getting it. Specifically, my character is proficient in Arcana and History, but not Religion or Nature; all the same, HL is showing +8 for all four skills (INT + double proficiency), instead of just the first two.

@ghost
Copy link

ghost commented Sep 10, 2017

I see two issues:

  1. The skill script should read:
    if (hero.child[skArcana].tagis[Helper.Proficient] <> 0) then
    perform hero.child[skArcana].assign[Helper.ProfDouble]
    endif
    component.BaseSkill <> 0 will always be true since the skills are in the baseskill array (always).

  2. Timing. You need to run the skill script post-levels after 15000 and before 20000. The Helper.Proficient tag doesn't get pushed on skills till the calc skProfBon runs at 15000. Just change the timing to 15500 and it works fine with the code change I suggest above.

ghost pushed a commit that referenced this issue Dec 18, 2017
COM_5ePack_UA - WarWiz.user missing update #676
ghost pushed a commit that referenced this issue Dec 18, 2017
COM_5ePack_UA - WarWiz.user missing update #676 - Lore Mastery fix
@ghost
Copy link

ghost commented Dec 18, 2017

Fixed Lore Mastery, it will now only add double proficiency to the skills you are proficient in and not all skills with next release.

@ghost ghost closed this as completed Dec 18, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants