on damage: message "something" does not error

[Nicofisi]

Code

on damage:
    message "damage"

this code loads with no errors, yet does nothing at runtime (neither sends the message to the victim nor to the attacker)

Expected behavior

It should error, saying that in the damage event either attacker or victim should be explicitly specified

[Pikachu920]

to add some info to this: it seems like the error is going off but gets stuck in a log handler somewhere

[BaeFell]

I always thought Skript errored saying that you need to specify the player receiving the message? Such as the attacker or the victim.

[Nicofisi]

@nfell2009 iirc people on skUnity said that it only errors when you explicitly use event-player or event-entity, aka not here

[Ofus-Will]

I thought it defaulted to the victim? 🤔

[Nicofisi]

@OfusMC nope, it does completely nothing

[TheBentoBox]

Not really sure what prio to put this at, I'm considering medium since I know many have encountered this behavior before including myself and it's unclear what's happening.

[TheLimeGlass]

Andrew made a fix for this iirc

[28andrew]

I tried to but I couldn't figure out how to print the error message in the part of the SkriptParser where I wrote the patch (Github name is set wrong :|): master...xXAndrew28Xx:fix-1415 (Skript.error would not work in this location for some reason)

[TheLimeGlass]

Isn't it the same system like the parse expression? Call it to listen then parse and an error gets printed

[28andrew]

Hmm I'll look into that. Thanks.

[TheLimeGlass]

Found and fixed bug;

The issue is this mess https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/registrations/EventValues.java#L165-L181

Readable version:

for (EventValueInfo<?, ?> ev : eventValues) {
    if (!c.isAssignableFrom(ev.c)) // Projectile would pass
        continue;
    if (!EventValues.checkExcludes(ev, e)) // EntityDamageByDamage (ev.event) is not assignable from EntityDamageEvent
        return null;
    if (ev.event.isAssignableFrom(e)) // EntityDamageByDamage (ev.event) is not assignable from EntityDamageEvent
        return (Getter<? extends T, ? super E>) ev.getter;
    if (!e.isAssignableFrom(ev.event)) // EntityDamageByDamage (ev.event) is not assignable from EntityDamageEvent
        continue;
    return new Getter<T, E>() {
        @Override
        @Nullable
        public T get(E event) {
            // This looks like a fix that was added afterwards, because lots of related events can get here.
            if (!ev.event.isInstance(event)) // EntityDamageByDamage (ev.event) is not an instance of EntityDamageEvent
                return null; // Why EffMessage with no command sender doesn't work for default expressions.
            return ((Getter<? extends T, E>) ev.getter).get(event);
        }
    };
}

The issue is that the event value https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java#L402 is taking priority, the projectile is an entity/commandsender, so it passes those isAssignableFrom, it passes all the event isAssignableFrom because EntityDamageByEntity is not assignable from EntityDamageEvent it's vice versa, and the getter will return null because EntityDamageByEntity is not an instance of EntityDamageEvent, so the EffMessage default expression sends the message to no consolesender when attempting to grab a default event value.