Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item names becoming their Material name when meta is changed #1658

Closed
KingAlterIV opened this issue Nov 5, 2018 · 1 comment
Closed

Item names becoming their Material name when meta is changed #1658

KingAlterIV opened this issue Nov 5, 2018 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@KingAlterIV
Copy link

KingAlterIV commented Nov 5, 2018 •
edited

Description

Pretty much, an item with lore will get its alias name change. If it's not, it'll show up with the correct alias name. ("diamond_sword" will be turned into "DIAMOND SWORD")

Steps to Reproduce

on inventory click:
	if event-item is stone:
		if lore of event-item is not set:
			broadcast "WITHOUT LORE %event-item%"
		else if lore of event-item is set:
			broadcast "WITH LORE %event-item%"

Expected Behavior

I expected it to print out the alias name instead of that other name.
("diamond_sword" instead of "DIAMOND SWORD")

Errors / Screenshots

http://i-enjoy-reading-man.ga/cbf5zh.png

Server Information

  • Server version/platform: 1.13.1 PaperSpigot
  • Skript version: Skript 2.3-beta1

Additional Context

No errors at all, but using type of event-item will fix it.
@Snow-Pyon Snow-Pyon changed the title Incorrect alias when item has a lore. Item names becoming their Material name when meta is changed Nov 6, 2018
Snow-Pyon pushed a commit that referenced this issue Nov 6, 2018
@FranKusmiruk
Reference item names by their Material (#1658)
55149f4 
Since ItemData could vary depending on the instance, using it as key
on a HashMap might not be reliable, we're better off referencing the
names by their type.
@Snow-Pyon
Copy link

Should be fixed for the next release.

@Snow-Pyon Snow-Pyon added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). completed The issue has been fully resolved and the change will be in the next Skript update. labels Nov 6, 2018
bensku added a commit that referenced this issue Nov 20, 2018
@bensku
Revert "Reference item names by their Material (#1658) Since ItemData…
f1b9d3e 
… could vary depending on the instance, using it as key on a HashMap might not be reliable, we're better off referencing the names by their type."

This reverts commit 55149f4.

The commit caused regressions such as the one described in #1695.
Same Material does not guarantee same display name!
bensku added a commit that referenced this issue Nov 20, 2018
@bensku
Fix ItemType hashCode (#1658)
aa5fdf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KingAlterIV @Snow-Pyon