Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'uncoloured message' doesn't remove §x #3106

Closed
GiraffeCubed opened this issue Jul 6, 2020 · 3 comments · Fixed by #3098
Closed

'uncoloured message' doesn't remove §x #3106

GiraffeCubed opened this issue Jul 6, 2020 · 3 comments · Fixed by #3098
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@GiraffeCubed
Copy link

GiraffeCubed commented Jul 6, 2020 •
edited
Loading

Description

When trying to uncolour a message in the new hex colour code system, the opening §x is not removed from the result, making it difficult to work with hex coloured messages.

Steps to Reproduce

on chat:
    send "%uncoloured message%"

Then send hex coloured message in chat
(See screenshot for resulting behaviour)

Expected Behavior

§x should be treated as a colour code, and removed from 'uncoloured message'

Errors / Screenshots

As you can see, the 'x' is left in
http://prntscr.com/tckvt7
(Giraffe was #FF0000, Cubed was &e)

Server Information

  • Server version/platform: Paper 1.16.1 (ver 73)
  • Skript version: 2.5 Alpha 5
@APickledWalrus
Copy link
Member

This will probably be fixed in #3098

@FranKusmiruk FranKusmiruk added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Jul 6, 2020
@APickledWalrus
Copy link
Member

image

patched if #3098 is merged

@APickledWalrus APickledWalrus mentioned this issue Jul 7, 2020
Merged
@Wealthyturtle Wealthyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 10, 2020
@Wealthyturtle Wealthyturtle reopened this Jul 10, 2020
@GiraffeCubed
Copy link
Author

I gave my affected code a test with #3098 and it is solved, thanks @APickledWalrus

@Wealthyturtle Wealthyturtle reopened this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Hex Color Support
5 participants
@GiraffeCubed @Wealthyturtle @ShaneBeee @APickledWalrus @FranKusmiruk