Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on Preparing Craft #323

Closed
ghost opened this issue Jan 4, 2017 · 3 comments
Closed

on Preparing Craft #323

ghost opened this issue Jan 4, 2017 · 3 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@ghost
Copy link

ghost commented Jan 4, 2017

Thanks for your great update.
I have a problem and want to know about it.

The code below doesn't work.

on preparing craft:
	message "hey" to player

Error message is "There is no player in an on prepare craft event".
I'd like to know it's bug or not. Thank you.
@bensku bensku removed the dev-needed label Jan 10, 2017
@bensku
Copy link
Member

bensku commented Jan 10, 2017

The event does not have player. However, it has inventory from which we can indirectly get player. Doing that for next release.

@bensku bensku added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 10, 2017
bensku added a commit that referenced this issue Jan 10, 2017
@bensku
Add player to PrepareItemCraftEvent (#323)
631248f
@TheBentoBox
Copy link
Member

Just tested in dev23, you can now message players in preparing craft events.

@ghost
Copy link
Author

ghost commented Jan 11, 2017

I appreciate to your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensku @TheBentoBox