Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named items not returning as ItemType #3347

Closed
ghost opened this issue Aug 29, 2020 · 6 comments
Closed

Named items not returning as ItemType #3347

ghost opened this issue Aug 29, 2020 · 6 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: high Issues with potentially high impact that could be harmful to users.

Comments

@ghost
Copy link

ghost commented Aug 29, 2020

Description

Errors, A LOT. of them.

Steps to Reproduce

Expected Behavior

No errors

Errors / Screenshots

https://pastebin.com/raw/knSmdyN6 (some may have appeared that aren't caused by the update, but... look at all those item stacks, they definitely worked before!)

Server Information

  • Server version/platform: 1.12.2 Paper
  • Skript version: 2.5 beta3

Additional Context

@Romitou
Copy link
Sponsor Member

Romitou commented Aug 29, 2020

I can confirm with Paper 1.15.2.

@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: high Issues with potentially high impact that could be harmful to users. labels Aug 29, 2020
@ShaneBeee ShaneBeee self-assigned this Aug 29, 2020
@ShaneBeee ShaneBeee changed the title beta3 breaks like all items? Named items not returning as ItemType Aug 29, 2020
@ShaneBeee
Copy link
Contributor

Ok, luckily this was an easy fix. But for future reference, please fill in the issue template and describe the actual issue.
I happened to know why this broke, but this isn't always the case. Saying "lots of errors" doesn't help us triage the issue in a lot of cases.

Help us help you!

@ShaneBeee ShaneBeee added the completed The issue has been fully resolved and the change will be in the next Skript update. label Aug 29, 2020
@iperrealistico
Copy link

Tested both Beta 2 and last nightly build... nope! The issue is still there, i want to check if the item has NO name applied on it:

if arg-player has arg-number of diamonds named "":
	remove arg-number of diamonds named "" from arg-player's inventory
	add {_worth} to arg-player's money
	... bla bla do stuff 😄 

Small gif where i rename diamond to testname, but the code i wrote above sees it as named ""

https://giphy.com/gifs/ehOBHL0qObLzL5wqs4

@iperrealistico
Copy link

@ShaneBeee does not think so 🤷‍♂️
look #3364 , he closed it as duplicate of this one

@iperrealistico
Copy link

For me this is not fixed yet. I can't check if an item has no name applied

@ShaneBeee
Copy link
Contributor

if name of item is not set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: high Issues with potentially high impact that could be harmful to users.
Projects
None yet
Development

No branches or pull requests

3 participants