Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge Old Variable Database Backups #5485

Open
1 task done
NotSoDelayed opened this issue Mar 2, 2023 · 5 comments
Open
1 task done

Purge Old Variable Database Backups #5485

NotSoDelayed opened this issue Mar 2, 2023 · 5 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@NotSoDelayed
Copy link
Contributor

Suggestion

Implement a new configurable core feature which purges old variables database backups after X days old.

Why?

Old backups are piled up after a long run overtime where beginners may have it unnoticed, and this system may come in handy to remove old backups as configured.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@Pikachu920
Copy link
Member

I'm open to this, but I think it should be disabled by default.

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Mar 4, 2023
@ExtraSmartMiner
Copy link

I think this be ultra nice because if you have a lot of auto restarts with a lot of variables you can rack up a huge file size pretty fast

@EquipableMC
Copy link
Contributor

I'm open to this, but I think it should be disabled by default.

This shouldn't be disabled by default. This should be set to 7 days or 14 days and the player can change it to however long they want it to be.

@NotSoDelayed
Copy link
Contributor Author

Even if the option is enabled by default, 7 or 14 days is consider short, and there are those people who are unaware of certain changes / features in Skript or any other plugins out there, which then I believe they will make their way to the generated files / configs to discover them, and in this topic we're talking about backups which may be crucial when the time comes.
You knew that they can change the duration of how long backups last, so I vouch for having this option disabled by default, then have users configure it.

@NotSoDelayed
Copy link
Contributor Author

Note PR available #6851

@sovdeeth sovdeeth added the PR available Issues which have a yet-to-be merged PR resolving it label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

6 participants