Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkriptEvent getter to ScriptLoader #3766

Merged
merged 2 commits into from Mar 3, 2021

Conversation

TPGamesNL
Copy link
Member

Description

Added a field, getter and setter (similar to ScriptLoader.currentEvents) to store the current SkriptEvent so that effects/expressions/conditions will know more about the event they're in during parse time. For example, an expression that can only be used in right click events, not other click events.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TPGamesNL TPGamesNL changed the title Update ScriptLoader.java Add SkriptEvent getter to ScriptLoader Feb 21, 2021
@TPGamesNL TPGamesNL added 2.5 feature Pull request adding a new feature. labels Feb 21, 2021
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could be useful. 👍

@FranKusmiruk FranKusmiruk merged commit 1f958b7 into SkriptLang:master Mar 3, 2021
FranKusmiruk pushed a commit that referenced this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants