Repeat Expression

[Fusezion]

Description

This PR adds a new repeat expression into skript, pattern usage is %string% repeated %integer% time[s]

---

Target Minecraft Versions: any
Requirements: none
Related Issues: none

[TheLimeGlass]

Skript has it's own implementation of multiply in StringUtils

Skript/src/main/java/ch/njol/util/StringUtils.java

Lines 291 to 313 in 6bf2341

	public static String multiply(final @Nullable String s, final int amount) {
	assert amount >= 0 : amount;
	if (s == null)
	return "";
	if (amount <= 0)
	return "";
	if (amount == 1)
	return s;
	final char[] input = s.toCharArray();
	final char[] multiplied = new char[input.length * amount];
	for (int i = 0; i < amount; i++)
	System.arraycopy(input, 0, multiplied, i * input.length, input.length);
	return new String(multiplied);
	}
	public static String multiply(final char c, final int amount) {
	if (amount == 0)
	return "";
	final char[] multiplied = new char[amount];
	for (int i = 0; i < amount; i++)
	multiplied[i] = c;
	return new String(multiplied);
	}

I haven't checked if it would be more efficient to use Skript's or not. The collection util in Java probably didn't exist back then. We need to ensure this is currently the most efficient operation count. The old method might even be better to replace with new, or vice versa.

[Fusezion]

Skript has it's own implementation of multiply in StringUtils

Skript/src/main/java/ch/njol/util/StringUtils.java

Lines 291 to 313 in 6bf2341

	public static String multiply(final @Nullable String s, final int amount) {
	assert amount >= 0 : amount;
	if (s == null)
	return "";
	if (amount <= 0)
	return "";
	if (amount == 1)
	return s;
	final char[] input = s.toCharArray();
	final char[] multiplied = new char[input.length * amount];
	for (int i = 0; i < amount; i++)
	System.arraycopy(input, 0, multiplied, i * input.length, input.length);
	return new String(multiplied);
	}
	public static String multiply(final char c, final int amount) {
	if (amount == 0)
	return "";
	final char[] multiplied = new char[amount];
	for (int i = 0; i < amount; i++)
	multiplied[i] = c;
	return new String(multiplied);
	}

I haven't checked if it would be more efficient to use Skript's or not. The collection util in Java probably didn't exist back then. We need to ensure this is currently the most efficient operation count. The old method might even be better to replace with new, or vice versa.

It's entirely possible that skript's method would be better with the fact it's built for string while nCopy seems to support
use of non string types and if I compare multiply with Java11 repeat the only difference is some limitations and checks most of everything else is the same. If you have any clue on how I could possibly test which one is more suited then I'd love to hear.

[Fusezion]

Moved it to multiply just to keep it with current standards of skript if we ever decide that multiply is outdated we can update it then

[Pikachu920]

Moved it to multiply just to keep it with current standards of skript if we ever decide that multiply is outdated we can update it then

I think lime was just suggesting you use the function in your code. as a name, I think multiply is a lot less clear than repeat. Also, what do you think about making this an expression? I think "string" repeated 5 times is probably clearer than repeat("string", 5)

[Fusezion]

I think lime was just suggesting you use the function in your code. as a name, I think multiply is a lot less clear than repeat. Also, what do you think about making this an expression? I think "string" repeated 5 times is probably clearer than repeat("string", 5)

I think I could do that tho would it be best to keep repeat function and add it as a side option like how round is
or just removing the function entirely and adding a %string% repeated %number% times

[Fusezion]

Changes should of been made now, sorry for the delay on those

[APickledWalrus]

Looks good to me! Nice work :)