New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated getTicks #5307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
breaking changes
Pull or feature requests that contain breaking changes (API, syntax, etc.)
labels
Jan 2, 2023
Some addons still use these methods: Addon usage (skUnity addons only)
There are a few options:
|
It's been deprecated since 2.2-v8 which was 1.8-1.9 days it's about time it's been executed |
I agree, I think it'd be best to add it to the addon patcher then |
UnderscoreTud
requested changes
Feb 17, 2023
UnderscoreTud
approved these changes
Feb 18, 2023
kiip1
approved these changes
Feb 21, 2023
AyhamAl-Ali
approved these changes
Aug 27, 2023
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
September 16, 2023 16:59
bd134d0
to
3f08853
Compare
Moderocky
approved these changes
Sep 17, 2023
Moderocky
added
the
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
label
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.8
Targeting a 2.8.X version release
breaking changes
Pull or feature requests that contain breaking changes (API, syntax, etc.)
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally removes getTicks and fromTicks integer return and makes getTicks and fromTicks the main long value return while deprecating getTicks_i and fromTicks_i due to API name change.
EffIgnite needed a rewrite to adapt and overall super old code that needed optimizations.
ExprBurnCookTime used the wrong getTicks the entire time, had to update that.