Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated getTicks #5307

Merged
merged 7 commits into from Sep 25, 2023
Merged

Remove deprecated getTicks #5307

merged 7 commits into from Sep 25, 2023

Conversation

TheLimeGlass
Copy link
Collaborator

Description

Finally removes getTicks and fromTicks integer return and makes getTicks and fromTicks the main long value return while deprecating getTicks_i and fromTicks_i due to API name change.

EffIgnite needed a rewrite to adapt and overall super old code that needed optimizations.
ExprBurnCookTime used the wrong getTicks the entire time, had to update that.

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) labels Jan 2, 2023
@TPGamesNL
Copy link
Member

Some addons still use these methods:

Addon usage (skUnity addons only)
getTicks
	SharpSK (maintained only on fork, 573 servers)
		EffCoreRestore
	Skcrew
		ExprWorldBorderSize
	Skellett-legacy (1414 servers)
		ExprMaxDamageTicks
	SkStuff (unmaintained)
		EffSetPathGoal
		ExprTimespanToNumber

fromTicks
	BunchSK (unmaintained)
		ExprDurationOfPotion
	Skellett-legacy (1414 servers)
		ExprMaxDamageTicks
	WolvSK (unmaintained)
		ExprCooldownLeftTime

There are a few options:

  1. Just remove them, maintained addons will have to be updated, the rest are in bad luck
  2. Add @UpForRemoval for a while, allow maintained addons to update
    1. I don't think this will help much
  3. Remove them and patch it with the addon patcher, all addons will continue working regardless of maintenance, if the server has the addon patcher installed.

@TheLimeGlass
Copy link
Collaborator Author

TheLimeGlass commented Jan 2, 2023

Some addons still use these methods:
Addon usage (skUnity addons only)

There are a few options:

1. Just remove them, maintained addons will have to be updated, the rest are in bad luck

2. Add `@UpForRemoval` for a while, allow maintained addons to update
   
   1. I don't think this will help much

3. Remove them and patch it with the [addon patcher](https://github.com/SkriptLang/AddonPatcher), all addons will continue working regardless of maintenance, if the server has the addon patcher installed.

It's been deprecated since 2.2-v8 which was 1.8-1.9 days it's about time it's been executed

@TPGamesNL
Copy link
Member

It's been deprecated since 2.2-v8 which was 1.8-1.9 days it's about time it's been executed

I agree, I think it'd be best to add it to the addon patcher then

@TheLimeGlass TheLimeGlass added the 2.8 Targeting a 2.8.X version release label Jan 3, 2023
sovdeeth added a commit to sovdeeth/Skript that referenced this pull request Jan 16, 2023
src/main/java/ch/njol/skript/util/Timespan.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/util/Timespan.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffIgnite.java Outdated Show resolved Hide resolved
TheLimeGlass and others added 2 commits August 27, 2023 02:30
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
@Moderocky Moderocky changed the base branch from master to dev/feature September 17, 2023 08:23
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 17, 2023
@TheLimeGlass TheLimeGlass merged commit 611813d into dev/feature Sep 25, 2023
6 checks passed
@TheLimeGlass TheLimeGlass deleted the fix/remove-getticks branch September 25, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants