Adds EffToggleCanPickUpItems + CondCanPickUpItems #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
changed the title
AyhamAl-Ali
requested changes
Jan 17, 2023
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
UnderscoreTud
requested changes
Jan 17, 2023
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/effects/EffToggleCanPickUpItems.sk
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Feb 4, 2023
src/main/java/ch/njol/skript/conditions/CondCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/effects/EffToggleCanPickUpItems.sk
Outdated
Show resolved
Hide resolved
sovdeeth
requested review from
TheLimeGlass
and removed request for
AyhamAl-Ali and
UnderscoreTud
TheLimeGlass
requested changes
Feb 14, 2023
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/effects/EffToggleCanPickUpItems.sk
Outdated
Show resolved
Hide resolved
AyhamAl-Ali
requested changes
Feb 14, 2023
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
UnderscoreTud
approved these changes
Feb 17, 2023
src/main/java/ch/njol/skript/effects/EffToggleCanPickUpItems.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
approved these changes
Mar 21, 2023
AyhamAl-Ali
approved these changes
Apr 16, 2023
Moderocky
pushed a commit
to Moderocky/Skript
that referenced
this pull request
Sep 16, 2023
NotSoDelayed
pushed a commit
to NotSoDelayed/Skript
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an effect to toggle the ability of a living entity to pick up items.
Adds a condition to check whether a living entity can pick up items.
Adds a test for both.
Target Minecraft Versions: any
Requirements:
Related Issues: #4185