Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yggdrasil Cleanup #5408

Merged
merged 9 commits into from Sep 20, 2023
Merged

Yggdrasil Cleanup #5408

merged 9 commits into from Sep 20, 2023

Conversation

kiip1
Copy link
Contributor

@kiip1 kiip1 commented Jan 28, 2023

Description

Refactors Yggdrasil to prevent single letter variables, unnecessary modifiers, fix a few bad practices and delete stuff that has been deprecated for 7 years.

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 29, 2023
@kiip1 kiip1 requested a review from Moderocky January 30, 2023 20:48
@TheLimeGlass TheLimeGlass self-requested a review February 4, 2023 02:46
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. :)

@Moderocky Moderocky changed the base branch from master to dev/feature September 17, 2023 08:20
@TheLimeGlass TheLimeGlass merged commit fa43514 into SkriptLang:dev/feature Sep 20, 2023
4 checks passed
@kiip1 kiip1 deleted the yggdrasil branch September 23, 2023 11:57
kiip1 added a commit to mlummh/mlum-skript that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants