Vector from direction #5502
Merged
Vector from direction #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
requested changes
Mar 9, 2023
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
From discussion with Pikachu in SkUnity discord, for allowing `northwards vector` and similar.
AyhamAl-Ali
approved these changes
Mar 12, 2023
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
UnderscoreTud
approved these changes
Mar 22, 2023
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Apr 18, 2023
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
…on.java Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
TheLimeGlass
requested changes
May 2, 2023
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorFromDirection.java
Outdated
Show resolved
Hide resolved
…on.java Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
TheLimeGlass
approved these changes
Jun 28, 2023
NotSoDelayed
pushed a commit
to NotSoDelayed/Skript
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a syntax to create vectors from directions:
vector[s] [from|in] [direction] %directions%This allows things like:
Relative directions will just be relative to the origin, with yaw/pitch 0.
I especially find the first example a useful replacement for the more unwieldy
vector from yaw player's yaw and pitch player's pitch.However, directions scare me so I'd love confirmation that this won't mess anything up, especially with how loose the syntax is.
Target Minecraft Versions:
Requirements:
Related Issues: