Adds CondHasLineOfSight

[sovdeeth]

Description

Adds CondHasLineOfSight. Checks if one or more living entities have unobstructed lines of sight to the target entities/locations.

---

Target Minecraft Versions:
Requirements:
Related Issues: #4185

[AyhamAl-Ali]

Nice PR ⚡

[TheLimeGlass]

This can be a PropertyCondition

[sovdeeth]

This can be a PropertyCondition

I considered that, but no other PropertyCondition I looked at had a second expression. Since I'd have to override the init anyway, as well as not use the PC register method (because of "has no line of sight"), I thought it'd be better to just use a normal condition.
Do you think it's worthwhile converting it to a property condition?

[TheLimeGlass]

This can be a PropertyCondition

I considered that, but no other PropertyCondition I looked at had a second expression. Since I'd have to override the init anyway, as well as not use the PC register method (because of "has no line of sight"), I thought it'd be better to just use a normal condition. Do you think it's worthwhile converting it to a property condition?

Yes, I don't think it needs no. You can also just keep how it's registered.

[sovdeeth]

This can be a PropertyCondition

I considered that, but no other PropertyCondition I looked at had a second expression. Since I'd have to override the init anyway, as well as not use the PC register method (because of "has no line of sight"), I thought it'd be better to just use a normal condition. Do you think it's worthwhile converting it to a property condition?

Yes, put the no as a parser mark.

Doesn't that allow x doesn't have no line of sight to y?

[sovdeeth]

I'm also not sure how I'd go about getting all the target without access to the event in PropertyCondition#check(T t).

[Ankoki]

I don't think this should be a PropertyCondition, as that aims at one expression not two

[Fusezion]

Little nitpick I had