New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Event: Enderman Escape & Escape Reason Expression #5633
Merged
APickledWalrus
merged 31 commits into
SkriptLang:dev/feature
from
NotSoDelayed:feature/enderman-teleport
Dec 18, 2023
Merged
New Event: Enderman Escape & Escape Reason Expression #5633
APickledWalrus
merged 31 commits into
SkriptLang:dev/feature
from
NotSoDelayed:feature/enderman-teleport
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested changes
Apr 24, 2023
src/main/java/ch/njol/skript/expressions/ExprEndermanEscapeReason.java
Outdated
Show resolved
Hide resolved
AyhamAl-Ali
requested changes
Apr 24, 2023
src/main/java/ch/njol/skript/expressions/ExprEndermanEscapeReason.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEndermanEscapeReason.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Apr 25, 2023
src/main/java/ch/njol/skript/expressions/ExprEndermanEscapeReason.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprEndermanEscapeReason.java
Outdated
Show resolved
Hide resolved
java.* imports should probably be going first instead of after all the imports as that's what Eclipse does and the majority of classes in Skript follow that standard. You can change this setting in your ide |
TheLimeGlass
requested changes
Apr 25, 2023
AyhamAl-Ali
approved these changes
Apr 26, 2023
TheLimeGlass
approved these changes
Apr 26, 2023
src/main/java/ch/njol/skript/expressions/ExprEndermanEscapeReason.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DelayedGaming conflicts
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
September 16, 2023 16:59
bd134d0
to
3f08853
Compare
Update ScriptCommand.java Co-authored-by: Moderocky <admin@moderocky.com>
Co-authored-by: Moderocky <admin@moderocky.com>
correct incorrect values
Add release model document Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com> Co-authored-by: Moderocky <admin@moderocky.com>
…age exists (SkriptLang#5942) (SkriptLang#6026) Fix cast throwing if existing variable for command storage exists (SkriptLang#5942) * Fix cast throwing if existing variable for command storage exists * Update src/main/java/ch/njol/skript/command/ScriptCommand.java --------- Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com> Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
…Attribute (SkriptLang#5978) (SkriptLang#6023) Fix NPE with invalid attributes and clean up ExprEntityAttribute (SkriptLang#5978) * Avoid NPE and clean up class * Update ExprEntityAttribute.java * Update src/main/java/ch/njol/skript/expressions/ExprEntityAttribute.java * Update src/main/java/ch/njol/skript/expressions/ExprEntityAttribute.java --------- Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
…kriptLang#6047) * Returns the old 2.6.4 duplicate variables section behaviour. * Add an error but i don't know what it's for * Add lots of brackets to keep walrus happy :}}} * Add load tracker to prevent multiple loading. * Prevent variable data wipe, fix another bug * Support IDEs from the dark ages that don't know what a star is and think it orbits the earth or something * add a test --------- Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ...
…Lang#6059) * Let's see if I am good at GH actions 🤞 * ops! * Use proper docs template reference when possible * Disable nightly javadocs generation with an option Each javadoc is ~50mb, which was causing the big size of the docs! while each docs generation is ~2mb only * Fix building * Revert pull changes They are not what fixed the issue, probably the old PRs aren't syncing for some reason * Update build.gradle --------- Co-authored-by: Moderocky <admin@moderocky.com>
Update dependabot.yml
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
….7.0 (SkriptLang#6070) Bump org.gradle.toolchains.foojay-resolver-convention Bumps org.gradle.toolchains.foojay-resolver-convention from 0.5.0 to 0.7.0. --- updated-dependencies: - dependency-name: org.gradle.toolchains.foojay-resolver-convention dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Bumps [org.easymock:easymock](https://github.com/easymock/easymock) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/easymock/easymock/releases) - [Changelog](https://github.com/easymock/easymock/blob/master/ReleaseNotes.md) - [Commits](easymock/easymock@easymock-5.1.0...easymock-5.2.0) --- updated-dependencies: - dependency-name: org.easymock:easymock dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
…0.1-SNAPSHOT (SkriptLang#6072) * Bump io.papermc.paper:paper-api Bumps io.papermc.paper:paper-api from 1.20.1-R0.1-SNAPSHOT to 1.20.2-R0.1-SNAPSHOT. --- updated-dependencies: - dependency-name: io.papermc.paper:paper-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Apply 1.20.2 to the test runner * Deprecate org.bukkit.util.Consumer usage in EntityData * Adapt against the Java Consumer instead of Bukkit's * Resolve existing method deprecation * Adapt against the Java Consumer instead of Bukkit's * Update developer note * Result in reflection for Bukkit Consumer * Resolve ThrownPotion Consumer * Result in reflection for Bukkit Consumer * Pretty else if * Add common reflective spawn method. * Use common spawn method in potion class. * Remove old suppression! * Whoops I forgot about the consumer * Don't need reflection import anymore :) * Thrown potion class --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com> Co-authored-by: TheLimeGlass <seantgrover@gmail.com> Co-authored-by: Moderocky <admin@moderocky.com>
Update pull_request_template.md
Initial (cherry picked from commit 389c002) Co-authored-by: Moderocky <admin@moderocky.com>
…n the section (SkriptLang#6033) Communicate local variables between consumer calls thanks pickle Co-authored-by: Moderocky <admin@moderocky.com>
…kriptLang#5966) * Remove PPCE listener and clean up Commands * Apply suggestions from code review Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com> * Update Commands.java * we hate breaking changes --------- Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com> Co-authored-by: Moderocky <admin@moderocky.com>
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Clean up vector classes and fix a few bugs.
Fix duplicate logging
NotSoDelayed
force-pushed
the
feature/enderman-teleport
branch
from
October 31, 2023 17:36
5b5a53c
to
8c7fec0
Compare
APickledWalrus
merged commit Dec 18, 2023
7178dc4
into
SkriptLang:dev/feature
37 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds EndermanEscapeEvent and its expression for getting escape reason into Skript!
My IDE had been re-arranging the imports. If there's a guideline should be followed, please let me know!
Target Minecraft Versions: any
Requirements: Paper 1.13+
Related Issues: -