More(!?) Converter and Comparator Improvements #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables Skript to compare to objects by converting them to the same type. Currently, this only supports converting Object A to the type of Object B and vice-versa. It is not currently possible for Skript to do Object A to some type C and Object B to some type C. That could be a heavier operation and potentially not work the performance degradation.
APickledWalrus
added
the
enhancement
AyhamAl-Ali
approved these changes
Jul 12, 2023
1 task
...and a test! this is to address SkriptLang#5848 essentially, this forces ExpressionList and LiteralList to ONLY use super types based on Skript ClassInfos (e.g. Object instead of something like Serializable) - probably needs more testing!
TheLimeGlass
requested changes
Aug 30, 2023
src/main/java/org/skriptlang/skript/lang/converter/ChainedConverter.java
Show resolved
Hide resolved
TheLimeGlass
previously requested changes
Aug 30, 2023
src/main/java/org/skriptlang/skript/lang/comparator/InverseComparator.java
Show resolved
Hide resolved
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
sovdeeth
approved these changes
Oct 1, 2023
APickledWalrus
added
the
bug
This will provide better toString context
Adds "exact exist" methods for usage during registration (e.g. checking if another addon has already registered a comparator/converter of some types)
|
@TheLimeGlass Feel free to review this again as I know you had interest in the toString formatting for these classes |
Moderocky
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I also considered implementing a resolution where Skript may find converters for A -> C and B -> C and then perform a same-type comparison for C. Not sure if this is worth it though. Thoughts welcome.
Target Minecraft Versions: any
Requirements: none
Related Issues:
This fixes an issue reported on Discord where Skript could not perform the following comparison:
if region at player is "<text>"- this comparison should work because Skript has a String -> Region Converter. Skript can now perform this comparison.