Add characters between and random characters expressions #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested changes
Jul 31, 2023
src/main/java/ch/njol/skript/expressions/ExprRandomCharacter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
AyhamAl-Ali
requested changes
Jul 31, 2023
src/main/java/ch/njol/skript/expressions/ExprRandomCharacter.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprRandomCharacter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Moderocky
approved these changes
Aug 24, 2023
TheLimeGlass
requested changes
Aug 27, 2023
src/main/java/ch/njol/skript/expressions/ExprRandomCharacter.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprRandomCharacter.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprRandomCharacter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
TheLimeGlass
approved these changes
Sep 19, 2023
sovdeeth
added
the
feature-ready
AyhamAl-Ali
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ExprCharacters and ExprRandomCharacter, analogues of ExprNumbers and ExprRandomNumber.
ExprCharacters gets all characters in a range, with an alphanumeric option.
ExprRandomCharacter gets 1 or more random characters from within a range, with an alpahnumeric option.
Debated using regex-like range syntax, like skquery, but decided to stick with the design laid out in #169. I'm willing to change that, though.
Target Minecraft Versions: any
Requirements:
Related Issues: #169