馃洜 Change player parsing to use name starting with
#5875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
enhancement
sovdeeth
requested changes
Aug 2, 2023
sovdeeth
approved these changes
Aug 2, 2023
TheLimeGlass
requested changes
Aug 3, 2023
TheLimeGlass
requested changes
Aug 3, 2023
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
TheLimeGlass
added
the
breaking changes
Moderocky
reviewed
Aug 25, 2023
TheLimeGlass
requested changes
Aug 27, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
TheLimeGlass
approved these changes
Oct 5, 2023
AyhamAl-Ali
added
the
feature-ready
Moderocky
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on this discord message and this and the related issue, it's better to use
name starting withinstead ofname containsfor accuracy and expected results. I had to kind-of use getPlayer method's code instead of the method itself to allow 'multiple players starting with name X' error to triggerOld behavior: (contains)
"SkriptDev" parsed as player # SkriptDev"s" parsed as player # SkriptDev"t" parsed as player # SkriptDev"y" parsed as player # noneNew Behavior: (starts with)
"SkriptDev" parsed as player # SkriptDev"s" parsed as player # SkriptDev"t" parsed as player # none"y" parsed as player # noneTarget Minecraft Versions:
Requirements:
Related Issues: