Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExprCommandInfo Enhancements #5889

Merged
merged 6 commits into from Oct 16, 2023
Merged

ExprCommandInfo Enhancements #5889

merged 6 commits into from Oct 16, 2023

Conversation

UnderscoreTud
Copy link
Member

Description

This PR makes ExprCommandInfo default to the current command if no command was passed into the expression. It also fixes a bug where isSingle returned the opposite value

Target Minecraft Versions: any
Requirements: none
Related Issues: #5885

@UnderscoreTud UnderscoreTud added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 8, 2023
AyhamAl-Ali
AyhamAl-Ali requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

src/main/java/ch/njol/skript/expressions/ExprCommandInfo.java Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandInfo.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCommandInfo.java Outdated Show resolved Hide resolved
AyhamAl-Ali
AyhamAl-Ali approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) labels Aug 27, 2023
@UnderscoreTud UnderscoreTud changed the base branch from master to dev/feature September 17, 2023 09:53
@TheLimeGlass TheLimeGlass merged commit f4084dc into dev/feature Oct 16, 2023
5 checks passed
@TheLimeGlass TheLimeGlass deleted the enhancement/expr-command-info branch October 16, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@Pikachu920 Pikachu920 Awaiting requested review from Pikachu920

Assignees
No one assigned
Labels
breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@UnderscoreTud @sovdeeth @Moderocky @TheLimeGlass @AyhamAl-Ali @Pikachu920