Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExprSentCommands and EvtPlayerCommandSend #5948

Merged
merged 20 commits into from Jan 1, 2024

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Aug 28, 2023

Description

Adds functionality to listen to and modify PlayerCommandSendEvents.
The sent commands can be modified, but not added to. Modifications are reflected in the tab completes available to the player. This has no effect on the commands they can actually run.

Would like opinions on the syntax for the event/expresssion.
Skbee uses command map to reference the collection of commands, which could be useful for ease of conversion.


Target Minecraft Versions: any
Requirements:
Related Issues: #3356

@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Aug 28, 2023
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! just few things

@Moderocky Moderocky changed the base branch from master to dev/feature September 17, 2023 07:44
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 17, 2023
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just about perfect :)

Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
@sovdeeth sovdeeth added the 2.8 Targeting a 2.8.X version release label Dec 30, 2023
@sovdeeth sovdeeth merged commit b6b63e6 into SkriptLang:dev/feature Jan 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants