Removes Projectile Bounce State Expr and Cond #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
TheLimeGlass
approved these changes
Sep 22, 2023
APickledWalrus
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Projectile bounce state relies on methods that do not work, and as such have been deprecated in Paper. (see PaperMC/Paper#7800)
My tests on 1.13 and 1.20 didn't indicate ANY behavioral change in projectiles whether the bounce state is true or false.
This PR removes the associated expression and condition as they are non-functional in 1.13+.
If anyone can demonstrate the syntax working in 1.13+, please respond to this PR.
Target Minecraft Versions:
Requirements:
Related Issues: