Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cow aliases to mooshrooms #6134

Merged
merged 5 commits into from
Apr 7, 2024
Merged

Add cow aliases to mooshrooms #6134

merged 5 commits into from
Apr 7, 2024

Conversation

TheLimeGlass
Copy link
Collaborator

Description

Add aliases for the word cow on mooshrooms

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. labels Oct 18, 2023
@TheLimeGlass TheLimeGlass changed the base branch from master to dev/feature October 18, 2023 09:37
@TheLimeGlass TheLimeGlass changed the base branch from dev/feature to dev/patch October 18, 2023 09:37
@ShaneBeee

This comment was marked as off-topic.

Sign in to view
@TheLimeGlass

This comment was marked as off-topic.

Sign in to view
@ShaneBeee

This comment was marked as off-topic.

Sign in to view
@TheLimeGlass TheLimeGlass added the up for debate When the decision is yet to be debated on the issue in question label Oct 18, 2023
@APickledWalrus
Copy link
Member

The debate here is whether Skript should stick strictly to the mob names used by Minecraft, or take some additional liberty in supporting other names used within the community.

I would say that if we are to add "aliases" like this, something like mushroom cow would be better (IIRC Minecraft itself used to refer to them as this internally). Definitely up for debate :)

sovdeeth
sovdeeth requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. I think mushroom cow is a perfectly fine name to use and I've been tripped up by this before.

However, this change makes mushroom a valid alias for mooshrooms which is not acceptable.

@sovdeeth sovdeeth added the 2.8 Targeting a 2.8.X version release label Dec 30, 2023
@sovdeeth sovdeeth added 2.9 Targeting a 2.9.X version release and removed 2.8 Targeting a 2.8.X version release labels Feb 17, 2024
@Moderocky Moderocky added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed up for debate When the decision is yet to be debated on the issue in question labels Apr 7, 2024
@Moderocky Moderocky merged commit 8c5f1d5 into dev/patch Apr 7, 2024
5 checks passed
@Moderocky Moderocky deleted the feature/mooshroom branch April 7, 2024 14:19
sovdeeth pushed a commit to sovdeeth/Skript that referenced this pull request Apr 18, 2024
@TheLimeGlass @Moderocky @sovdeeth
Add cow aliases to mooshrooms (SkriptLang#6134)
6921f2c 
* Add cow aliases to mooshrooms

* Update default.lang

* Update default.lang

---------

Co-authored-by: Moderocky <admin@moderocky.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees
No one assigned
Labels
2.9 Targeting a 2.9.X version release aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheLimeGlass @ShaneBeee @APickledWalrus @sovdeeth @Moderocky