Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ability to listen to cancelled events #6207

Merged
merged 18 commits into from
Apr 7, 2024
Merged

Adds ability to listen to cancelled events #6207

merged 18 commits into from
Apr 7, 2024

Commits on Nov 30, 2023

  1. Hey! Listen! 

    Adds functionality to allow events to listen to cancelled events only, uncancelled only (previous behavior), and both.
Deprecates listenCancelled (breaking change for EvtResurrect)
    @sovdeeth
    sovdeeth committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    cad575f View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: _tud <98935832+UnderscoreTud@users.noreply.github.com>
    @sovdeeth @UnderscoreTud
    sovdeeth and UnderscoreTud committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    eb97afe View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Allow events to have specific default listening behavior 

    Removes breaking change from EvtResurrect.
Refactors some of SkriptEventHandler
Errors for events that don't support cancelling
Bug fix for data leak via EventData
    @sovdeeth
    sovdeeth committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    80d4b1f View commit details
    Browse the repository at this point in the history

  2. revert incorrect java doc change

    @sovdeeth
    sovdeeth committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    2b770e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Streamline setting default behavior

    @sovdeeth
    sovdeeth committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    576d60b View commit details
    Browse the repository at this point in the history

  2. indentation

    @sovdeeth
    sovdeeth committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    fb4281c View commit details
    Browse the repository at this point in the history

  3. Prevent any sort of listening behavior on events that can't be cancel… 

    …led. Reduce local complexity in SkriptEventHandler
    @sovdeeth
    sovdeeth committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    222d2ee View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'dev/feature' into cancelled-events-2

    @Moderocky
    Moderocky committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    6b68174 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Merge branch 'dev/feature' into cancelled-events-2

    @sovdeeth
    sovdeeth committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    c2c831c View commit details
    Browse the repository at this point in the history

  2. Fix merge mistake

    @sovdeeth
    sovdeeth committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    2476d72 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
    @sovdeeth @APickledWalrus
    sovdeeth and APickledWalrus committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9bcaeff View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Requested Changes

    @sovdeeth
    sovdeeth committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    c610638 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/dev/feature' into cancelled-ev… 

    …ents-2
    @sovdeeth
    sovdeeth committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    29d6662 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. Cancelled Event Test

    @sovdeeth
    sovdeeth committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    30ccdad View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'dev/feature' into cancelled-events-2

    @sovdeeth
    sovdeeth committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    69e42e8 View commit details
    Browse the repository at this point in the history

  2. Fix merge mistakes 

    I need to stop using the browser for merge conflicts
    @sovdeeth
    sovdeeth committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0ed7f6e View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Merge branch 'dev/feature' into cancelled-events-2

    @sovdeeth
    sovdeeth committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    e52234c View commit details
    Browse the repository at this point in the history

  2. Update SkriptEventHandler.java

    @sovdeeth
    sovdeeth committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    031ed26 View commit details
    Browse the repository at this point in the history