Add more flexible static parse method #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pikachu920
added
the
enhancement
Pikachu920
commented
Jan 6, 2024
| */ | ||
| @Nullable | ||
| public static ParseResult parse(String text, SkriptPattern pattern, int parseFlags, ParseContext parseContext) { | ||
| return parse(text, pattern.toString(), parseFlags, parseContext); |
There was a problem hiding this comment.
the idea here is to add a SkriptPattern overload now so that if it becomes possible to parse the text more performantly with the SkriptPattern, we can change the implementation to do so! that way addon developers can start using this now with the potential of future improvements.
sovdeeth
approved these changes
Jan 6, 2024
AyhamAl-Ali
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some addons (including skript-reflect) are using the private
parse_imethod reflectively. This PR adds a proper way to do the same thing.Target Minecraft Versions: any
Requirements: none
Related Issues: none