Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force "to location" in ExprLocationFromVector #6310

Merged

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Jan 8, 2024

Description

Requires to location in %vector% to location in %world% as %vector% in %world% was conflicting with some addon syntaxes and in my opinion, matched much to broadly.


Target Minecraft Versions: any
Requirements: none
Related Issues: #6285

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.8 Targeting a 2.8.X version release labels Jan 8, 2024
@AyhamAl-Ali AyhamAl-Ali added the breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) label Jan 8, 2024
@sovdeeth
Copy link
Member Author

sovdeeth commented Jan 8, 2024

I don't think this should be breaking changes, as the expression was only re-added in 2.8

@Pikachu920
Copy link
Member

I don't think this should be breaking changes, as the expression was only re-added in 2.8

agree, i think it's reasonable to consider it a compatibility bug fix for a bug introduced in the prerelease

@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) labels Jan 8, 2024
@APickledWalrus APickledWalrus merged commit e418f6c into SkriptLang:dev/feature Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants