Fix "parsed as a player" Not Working #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
sovdeeth
approved these changes
Jan 10, 2024
AyhamAl-Ali
approved these changes
Jan 10, 2024
AyhamAl-Ali
added
the
patch-ready
|
Do you think there are other classinfos that might be broken due to the PARSE context? |
|
I took a look but did not find any other ones :) |
Sounds like yay 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes "parsed as a player" not working. The issue was caused by the new PARSE ParseContext not being considered in the Player ClassInfo's parse method. I have confirmed that it works as expected now.
Target Minecraft Versions: any
Requirements: none
Related Issues: