Fix ExprPlain always getting the base material from ItemTypes #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
AyhamAl-Ali
approved these changes
Feb 2, 2024
APickledWalrus
approved these changes
Feb 2, 2024
sovdeeth
added
the
patch-ready
|
can we add a regression test please? |
I didn't know how to do one that didn't have an inherently random chance of failing. Any advice? |
Moderocky
approved these changes
Feb 3, 2024
i think you could use easymock to ensure getRandom gets called on the itemtype |
Pikachu920
requested changes
Feb 4, 2024
src/test/java/org/skriptlang/skript/test/tests/regression/ExprPlainAliasTest.java
Show resolved
Hide resolved
…PlainAliasTest.java Co-authored-by: Pikachu920 <28607612+Pikachu920@users.noreply.github.com>
Pikachu920
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calls ItemType#getRandom() to ensure the item is a accurate representation of the alias (e.g. any sword) before getting the material.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5994