Fix parsing errors caused by special characters #6455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
bug
sovdeeth
approved these changes
Feb 22, 2024
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that could occur with the keyword search (#5103) system that caused valid code with special characters to fail to parse.
This issue is caused by the fact that the problematic code assumes
String#toLowerCasewill result in a String of the same length, which is not guaranteed. As a result, the used and returned indices do not align between the regular and converted strings.To correct this issue, I have moved the code away from using lowercase conversion. Instead, it uses
String#regionMatches(case-insensitive) instead ofString#startsWithwithString#toLowerCaseto accomplish the same thing.Test included! :)
Target Minecraft Versions: any
Requirements: none
Related Issues: