EntityData - check if entity can spawn #6484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
bug
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
APickledWalrus
approved these changes
Mar 6, 2024
AyhamAl-Ali
reviewed
Mar 7, 2024
AyhamAl-Ali
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a check to see if a specific entity can spawn dependant on data packs.
Minecraft has started adding "Experimental Datapacks" which allow the server owner to use new things which are aimed for the next major update.
Currently in Skript, if a data pack is not enabled, and you attempt to spawn one of these entities an error is thrown.
This applies a check before spawning the entity.
I added a method rather than just directly applying this in the spawn method, this way classes which extend and override this method can also check using this method.
Also fixed a couple typos that were right there.
NOTE: Incase anyone wonders, we don't have to do this for items too. You can actually give an experimental item to a player and it will have in the lore "Disabled Item"
Same with setting a block, it works.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6483