Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Player name/UUID in variables warning. #6505

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Remove Player name/UUID in variables warning. #6505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e9684
Update VariableString.java
sovdeeth Mar 21, 2024
118014d
Merge branch 'dev/feature' into remove/uuid-warnings
Moderocky Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/main/java/ch/njol/skript/lang/VariableString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,16 +224,6 @@ public static VariableString newInstance(String original, StringMode mode) {
log.printErrors("Can't understand this expression: " + original.substring(exprStart + 1, exprEnd));
return null;
} else {
if (
mode == StringMode.VARIABLE_NAME &&
!SkriptConfig.usePlayerUUIDsInVariableNames.value() &&
OfflinePlayer.class.isAssignableFrom(expr.getReturnType())
) {
Skript.warning(
"In the future, players in variable names will use the player's UUID instead of their name. " +
"For information on how to make sure your scripts won't be impacted by this change, see https://github.com/SkriptLang/Skript/discussions/6270."
);
}
strings.add(expr);
}
log.printLog();
Expand Down