Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples for Elements expression #6526

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update examples for Elements expression #6526

merged 2 commits into from
Apr 3, 2024

Conversation

Phill310
Copy link
Contributor

@Phill310 Phill310 commented Apr 2, 2024

Description

This PR adds more examples to ExprElements to showcase syntax from 2.7 and 2.8


Target Minecraft Versions: any
Requirements: none
Related Issues: #6397

Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ⚡

src/main/java/ch/njol/skript/expressions/ExprElement.java Outdated Show resolved Hide resolved
@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 3, 2024
@sovdeeth sovdeeth changed the base branch from master to dev/patch April 3, 2024 05:07
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good with Ayham's changes

Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 3, 2024
@Moderocky Moderocky merged commit 972dd38 into SkriptLang:dev/patch Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants