Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated syntax warning type #6549

Merged

Conversation

sovdeeth
Copy link
Member

Description

For use when we intend to remove a syntax in a future version. The warning is locally, but not globally, suppressible for those who refuse to update.

I chose to make it a static method, as opposed to an automatic warning in the parser, so that we can call it with whatever message is appropriate in a element's init method.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added feature Pull request adding a new feature. 2.9 Targeting a 2.9.X version release labels Apr 10, 2024
@UnderscoreTud UnderscoreTud self-requested a review April 10, 2024 20:21
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I will support this PR later by implementing the required annotations for docs

Copy link
Member

@UnderscoreTud UnderscoreTud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to ExprVectorArithmetic while you're at it

@AyhamAl-Ali AyhamAl-Ali added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Apr 10, 2024
@sovdeeth
Copy link
Member Author

Can you add this to ExprVectorArithmetic while you're at it

sure

@sovdeeth sovdeeth merged commit c19f1f7 into SkriptLang:dev/feature May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants