Adds Item Cooldown Event #6570
Adds Item Cooldown Event #6570
Conversation
| Skript.registerEvent("Unknown Command", SimpleEvent.class, UnknownCommandEvent.class, "[player] (wrong|unknown) (cmd|command) [send|use]") | ||
| .description("Called when the player uses a command that does not exist.") | ||
| .examples( | ||
| "on unknown command:", | ||
| "\tset event-unknown command message to \"Hey, this command does not exist.\"" | ||
| ) | ||
| .since("INSERT VERSION"); |
There was a problem hiding this comment.
your branch isn't clean, this is from your old pr.
You may want to restart this pr with a clean branch.
| .since("INSERT VERSION"); | ||
|
|
||
| Skript.registerEvent("Player Item Cooldown", SimpleEvent.class, PlayerItemCooldownEvent.class, "[player] item cool[ ]down") | ||
| .description("Called when a player's item cooldown changes.", " ","You must at least wait 1 tick if you need the cooldown or check it", "Because the cooldown won't have been set on the item itself when the event is called in case something wants to cancel or modify the cooldown.") |
There was a problem hiding this comment.
Why not modify the item cooldown expression to allow it to get/set the event value if it's used in this event?
There was a problem hiding this comment.
and should i just have event-integer in the BukkitEventValues
There was a problem hiding this comment.
by editing the getter and changer in the expression, there are examples in things like ExprExperience, for example.
And no, I would not provide event-integer. I would provide event-timespan, though.
There was a problem hiding this comment.
ExprItemCooldown doesn't look like ExprExperience class :/
There was a problem hiding this comment.
actually i found that setting it in the event will keep setting it forever, because if i set that it calls the event
There was a problem hiding this comment.
yes that's exactly why the expression needs a changer that modifies the event's values instead of using setCooldown()
You may also want to prevent setting the cooldown after a delay in the event, but that's optional.
There was a problem hiding this comment.
but for modifing the expression, how should i change that since it uses setCooldown(), do i add a checker to check if event instanceof PlayerItemCooldownEvent?
There was a problem hiding this comment.
and do other things in that
and if its not it does its regular thing? or thats a bad idea
There was a problem hiding this comment.
yes that's exactly why I told you to look at ExprExperience
Description
Adds the item cooldown event to skript
Target Minecraft Versions: any
Requirements: none
Related Issues: #6569