Looking at locations permits (relative) locations without worlds. #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
added
bug
sovdeeth
approved these changes
Apr 19, 2024
APickledWalrus
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if you asked an entity to look at a location that had no attached world it would fail with an error.
Now, it will replace the location with the equivalent one in the entity's world.
Note that this won't fix entities being asked to look at locations in different worlds (which I presume will probably error or do nothing, I don't know how Minecraft deals with that) but that seemed a little out of scope for this bug fix.
This should also fix the equivalent issue in legacy versions which use the old mob goal. I don't know if this issue occurred there, but in the case that it did I've done my best to support it.
Target Minecraft Versions: any
Requirements: none
Related Issues: closes #6476