Fix AIIOB in Variable SET changer #6600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
APickledWalrus
approved these changes
Apr 22, 2024
|
rerequest due to behavior change (set null -> don't change at all) |
Moderocky
approved these changes
Apr 23, 2024
sovdeeth
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Variable's SET changer assumes that delta is either an array of length >=1 or null, and doesn't properly handle empty arrays in some cases. This adds a check for empty arrays, which then just ignores the set.
Target Minecraft Versions: any
Requirements: none
Related Issues: SkriptLang/skript-reflect#99