Copy the SimpleLiteral backing data instead of exposing it. #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
added
bug
UnderscoreTud
approved these changes
May 10, 2024
APickledWalrus
approved these changes
May 10, 2024
sovdeeth
approved these changes
May 10, 2024
sovdeeth
pushed a commit
to sovdeeth/Skript
that referenced
this pull request
May 30, 2024
…ng#6683) Use copy array whenever data could be modified.
sovdeeth
pushed a commit
to sovdeeth/Skript
that referenced
this pull request
May 30, 2024
…ng#6683) Use copy array whenever data could be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of directly exposing the so-called "constant" data array, SimpleLiteral now returns an array copy of it.
This stops a malformed syntax (e.g. an addon syntax) from just doing
values[0] = ...and permanently changing the literal value for all future reads.Target Minecraft Versions: any
Requirements: none
Related Issues: fixes #6682