Particle Compatibility Improvements #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of particles probably don't work though
APickledWalrus
added
bug
|
Uh oh, the tests are failing because of a Vibration reference! |
1 task
sovdeeth
approved these changes
May 29, 2024
sovdeeth
added
2.8
sovdeeth
pushed a commit
to sovdeeth/Skript
that referenced
this pull request
May 30, 2024
* first pass at updating lang entries * Rewrite Particle lang entries A lot of particles probably don't work though * Add a test * Fix block marker particles * Add support for multiple expressions in a particle pattern * first pass at new data suppliers * Fix a few issues related to new suppliers * Data supplier touchups * Fix broken particles --------- Co-authored-by: Moderocky <admin@moderocky.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix particle compatibility between versions and fix some other issues that have arisen, especially after the 1.20.5 update (where the Particle enum saw major changes). For this, I have remade the particle definitions in the default language file. They are organized based on the Spigot Particle enum as of 1.20.6, with duplicate definitions for particles that had name changes present.
I have also gone ahead and rewritten the Data Suppliers for Particles with extra data. To ensure all particle are representable, I have made some tweaks to the way data is passed to the suppliers. For visual effects with patterns containing multiple expressions, they receive an array of values (may contain null).
This PR is not aiming to make any major changes to the Visual Effect system.
While the test suite (hopefully) passes, in-game testing still needs to be performed.
Target Minecraft Versions: any
Requirements: none
Related Issues: