Add support for spawning dropped items #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
APickledWalrus
requested changes
May 30, 2024
sovdeeth
changed the title
Moderocky
requested changes
May 30, 2024
Moderocky
approved these changes
May 31, 2024
UnderscoreTud
approved these changes
May 31, 2024
sovdeeth
added
the
patch-ready
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Moderocky
force-pushed
the
fix/spawn-dropped-items-1.17
branch
from
6a7d90a
to
ff8051a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows DroppedItemData to be spawned via the World#dropItem method.
I'm kind of shaky on how the EntityData system works, so please correct me if I misunderstood parts!
This is marked as a bug fix since you could
spawn dropped stoneand it would do nothing, despite the fact that logically it should work, since you can drop stone just fine.Target Minecraft Versions: 1.17+
Requirements: none
Related Issues: #6745