Fix PotionData NPE #6757
Merged
Fix PotionData NPE #6757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
Fusezion
approved these changes
Jun 3, 2024
Moderocky
approved these changes
Jun 3, 2024
sovdeeth
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an NPE that can occur on when attempting to obtain the potion effects of a potion without a base type.
I have removed the reflection usage for a method that was originally removed when I made the 1.20.5+ support PR. The method seems to have been added back in. However, I am forcing the usage of the recommended method when it is available.
Target Minecraft Versions: any
Requirements: none
Related Issues: