Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Adape go2sky v1.0.0 #16

Merged
merged 7 commits into from
Apr 6, 2021
Merged

Adape go2sky v1.0.0 #16

merged 7 commits into from
Apr 6, 2021

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Apr 6, 2021

No description provided.

@mrproliu mrproliu marked this pull request as draft April 6, 2021 10:06
@mrproliu
Copy link
Contributor Author

mrproliu commented Apr 6, 2021

Hi, @kezhenxu94. I found an error when upgrading the go-micro plugin to the newest go2sky version. I think the current gRPC version of goapi conflicts with go-micro.
Current go-micro plugin needs gRPC version v1.26.0 and the goapi is using gRPC version 1.36.0. Could you help to see?

@wu-sheng
Copy link
Member

wu-sheng commented Apr 6, 2021

Hi, @kezhenxu94. I found an error when upgrading the go-micro plugin to the newest go2sky version. I think the current gRPC version of goapi conflicts with go-micro.
Current go-micro plugin needs gRPC version v1.26.0 and the goapi is using gRPC version 1.36.0. Could you help to see?

Could we upgrade the go-micro version?

@mrproliu
Copy link
Contributor Author

mrproliu commented Apr 6, 2021

Hi, @kezhenxu94. I found an error when upgrading the go-micro plugin to the newest go2sky version. I think the current gRPC version of goapi conflicts with go-micro.
Current go-micro plugin needs gRPC version v1.26.0 and the goapi is using gRPC version 1.36.0. Could you help to see?

Could we upgrade the go-micro version?

Current 1.18.0 is go-micro lastest v1 release. Unless we only support V2 or later, I haven't tried which V2 version will be compatible.

@kezhenxu94
Copy link
Member

I'd rather we drop support for go-micro 1.x as its latest version had been v3 and the last version of 1.x is ~1.5 year ago,

@wu-sheng
Copy link
Member

wu-sheng commented Apr 6, 2021

I'd rather we drop support for go-micro 1.x as its latest version had been v3 and the last version of 1.x is ~1.5 year ago,

Make sense to me too. go ecosystem is usually upgrading to the latest, at least today, they still are.

@wu-sheng wu-sheng added this to the 1.0.0 milestone Apr 6, 2021
@mrproliu mrproliu marked this pull request as ready for review April 6, 2021 14:31
@wu-sheng wu-sheng requested a review from arugal April 6, 2021 14:31
@wu-sheng
Copy link
Member

wu-sheng commented Apr 6, 2021

@arugal Do you have time to recheck?

Copy link
Member

@arugal arugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit c0c83ec into master Apr 6, 2021
@wu-sheng wu-sheng deleted the adapt-go2sky-1.0.0 branch April 6, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants