Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Support use zap to transmit trace context to log #20

Merged
merged 4 commits into from
May 27, 2021
Merged

Support use zap to transmit trace context to log #20

merged 4 commits into from
May 27, 2021

Conversation

mrproliu
Copy link
Contributor

See SkyAPM/go2sky#104
Support the zap log framework

@mrproliu mrproliu added enhancement New feature or request plugin labels May 27, 2021
@mrproliu mrproliu added this to the 1.1.0 milestone May 27, 2021
@mrproliu mrproliu requested review from wu-sheng and arugal May 27, 2021 05:19
wu-sheng
wu-sheng approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @arugal Please recheck.

@wu-sheng
Copy link
Member

Should we consider releasing 1.1.0?

arugal
arugal approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@arugal arugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed to release v1.0.1 :)

@wu-sheng wu-sheng merged commit 81ed892 into SkyAPM:master May 27, 2021
@wu-sheng
Copy link
Member

v1.0.1 or v1.1.0. I assume as new features and versions involved, we should consider 1.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@arugal arugal arugal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request plugin
Projects
None yet
Milestone
1.1.0
3 participants
@mrproliu @wu-sheng @arugal