Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

chore: merge kratos component ids #29

Merged
merged 1 commit into from
Aug 11, 2021
Merged

chore: merge kratos component ids #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions kratos/kratos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ import (
)

const (
componentIDGoKratosServer = 5010
componentIDGoKratosClient = 5011
componentIDKratos = 5010
)

type Option func(*options)
Expand Down Expand Up @@ -66,7 +65,7 @@ func Server(tracer *go2sky.Tracer, opts ...Option) middleware.Middleware {
}
defer func() { span.End() }()

span.SetComponent(componentIDGoKratosServer)
span.SetComponent(componentIDKratos)
span.SetSpanLayer(agentv3.SpanLayer_RPCFramework)

if md, ok := metadata.FromServerContext(ctx); ok {
Expand Down Expand Up @@ -108,7 +107,7 @@ func Client(tracer *go2sky.Tracer, opts ...Option) middleware.Middleware {
}
defer func() { span.End() }()

span.SetComponent(componentIDGoKratosClient)
span.SetComponent(componentIDKratos)
span.SetSpanLayer(agentv3.SpanLayer_RPCFramework)

if md, ok := metadata.FromClientContext(ctx); ok {
Expand Down
4 changes: 2 additions & 2 deletions kratos/test/expected.data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ segmentItems:
spanLayer: RPCFramework
startTime: {{ gt .startTime 0 }}
endTime: {{ gt .endTime 0 }}
componentId: 5011
componentId: 5010
isError: false
spanType: Exit
peer: 'kratosserver:8000'
Expand All @@ -93,7 +93,7 @@ segmentItems:
spanLayer: RPCFramework
startTime: {{ gt .startTime 0 }}
endTime: {{ gt .endTime 0 }}
componentId: 5011
componentId: 5010
isError: false
spanType: Exit
peer: 'kratosserver:9000'
Expand Down