Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

feat: add ent plugin #51

Closed
wants to merge 1 commit into from
Closed

feat: add ent plugin #51

wants to merge 1 commit into from

Conversation

elza2
Copy link
Contributor

@elza2 elza2 commented Sep 22, 2022

feat: add ent plugin, https://github.com/ent/ent

@wu-sheng wu-sheng added this to the 1.6.0 milestone Sep 22, 2022
@wu-sheng wu-sheng added enhancement New feature or request plugin labels Sep 22, 2022
ent/README.md Outdated
select {}
}
```
![img.png](img.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should keep img in the doc and GitHub repo. This could be easily expired, such as currently, v8(you provided) has not been maintained anymore.

https://skywalking.apache.org/events/deprecate-v8/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this link and v8 sceenshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arugal
Copy link
Member

arugal commented Sep 22, 2022

@arugal
Copy link
Member

arugal commented Sep 22, 2022

@xiaohuo473225193 Your E2E test failed, please check

https://github.com/SkyAPM/go2sky-plugins/actions/runs/3105207395/jobs/5030577992#step:4:7

//

// Package ent is a plugin that can be used to trace Ent framework.
package ent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see the code for testing, what did I miss?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry,my mistake.

@elza2
Copy link
Contributor Author

elza2 commented Sep 23, 2022

ent Automatically generate code. golangci lint can ignore it?

@wu-sheng
Copy link
Member

It is better if you could test this on your own fork repo's GitHub action.

@elza2 elza2 closed this Sep 23, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
elza2 pushed a commit to elza2/go2sky-plugins that referenced this pull request Nov 14, 2022
@elza2 elza2 mentioned this pull request Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request plugin
Projects
None yet
3 participants