-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
ent/README.md
Outdated
select {} | ||
} | ||
``` | ||
![img.png](img.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should keep img in the doc and GitHub repo. This could be easily expired, such as currently, v8(you provided) has not been maintained anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this link and v8 sceenshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Hi @xiaohuo473225193 Welcome to contribute :) You need to add |
@xiaohuo473225193 Your E2E test failed, please check https://github.com/SkyAPM/go2sky-plugins/actions/runs/3105207395/jobs/5030577992#step:4:7 |
// | ||
|
||
// Package ent is a plugin that can be used to trace Ent framework. | ||
package ent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see the code for testing, what did I miss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry,my mistake.
ent Automatically generate code. golangci lint can ignore it? |
It is better if you could test this on your own fork repo's GitHub action. |
feat: add ent plugin, https://github.com/ent/ent