This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
fix(grpc-reporter): fix close stream to avoid goroutine leaks #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,there is an usage mistake on grpc stream control
here is the note from grpc doc
note that when stream is abort,one of those action should be done but now none of them was execute
it lead a result that ,when stream connection recreate(such as using load balance),a goroutine created from
grpc.newClientStream
leakshttps://godoc.org/google.golang.org/grpc#ClientConn.NewStream