Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Close coq#18636 and add some code comments
Fixed by reverting fea5fcc The reason the first abstract changes the behaviour is that it changes which branch we take in https://github.com/coq/coq/blob/3d86c1d4569b0a25a00677833b9f47c3059a8345/vernac/declare.ml#L1826 Why we have this code is not clear but removing it (so it becomes just `if not poly && keep_body_ucst_separate`) causes undefined universe anomaly at https://github.com/coq/coq/blob/3d86c1d4569b0a25a00677833b9f47c3059a8345/test-suite/success/rewrite.v#L50 In any case with this code and fea5fcc (indeed from coq#17745) we use an unminimized initial_euctx which has `{foo.5} |= Set = foo.5` which is added to the global env (we are in univ monomorphic mode), and since monomorphic universes are declared `> Set` we get the error. I guess short term we should revert fea5fcc and long term we should look into not checking is_empty_private_constants. (cherry picked from commit 14685d5)
- Loading branch information