Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese Symbols #235

Closed
theCapypara opened this issue May 20, 2022 · 4 comments · Fixed by UsernameFodder/pmdsky-debug#180
Closed

Japanese Symbols #235

theCapypara opened this issue May 20, 2022 · 4 comments · Fixed by UsernameFodder/pmdsky-debug#180
Labels
help wanted Extra attention is needed jp-support
Projects
Core: All open issues

Comments

@theCapypara
Copy link
Member

theCapypara commented May 20, 2022 •
edited

The following pmdsky-debug symbols would need to be defined for the JP ROM for SkyTemple to support it:

arm9:

  • DebugPrint0
  • DebugPrint
  • SaveScriptVariableValue
  • SaveScriptVariableValueAtIndex
  • GetDebugFlag
  • GetDebugLogFlag
  • SetDebugFlag
  • SetDebugLogFlag
  • SCRIPT_VARS
  • SCRIPT_VARS_LOCALS
  • CART_REMOVED_IMG_DATA
  • DEFAULT_PARTNER_ID
  • DEFAULT_HERO_ID
  • PARTNER_START_LEVEL
  • HERO_START_LEVEL
  • SPECIAL_EPISODE_MAIN_CHARACTERS
  • DUNGEON_DATA_LIST
  • DUNGEON_RESTRICTIONS
  • SECONDARY_TERRAIN_TYPES
  • MAP_MARKER_PLACEMENTS
  • GUEST_MONSTER_DATA
  • MIN_IQ_EXCLUSIVE_MOVE_USER
  • MIN_IQ_ITEM_MASTER
  • IQ_GUMMI_GAIN_TABLE
  • GUMMI_BELLY_RESTORE_TABLE
  • WONDER_GUMMI_IQ_GAIN
  • JUICE_BAR_NECTAR_IQ_GAIN
  • IQ_SKILLS
  • IQ_SKILL_RESTRICTIONS
  • IQ_GROUP_SKILLS
  • MONSTER_SPRITE_DATA
  • RANK_UP_TABLE
  • LOADED_OVERLAY_GROUP_1
  • GAME_STATE_VALUES
  • LANGUAGE_INFO_DATA
  • GAME_MODE
  • NOTIFY_NOTE

ram:

  • SCRIPT_VARS_VALUES
  • DEBUG_SPECIAL_EPISODE_NUMBER

arm9 extra (introduced via patch, definitions in skytemple-files):

  • COMPRESSED_IQ_GROUP_SKILLS
  • EXTRA_DUNGEON_DATA
  • GUEST_MONSTER_DATA2

overlay0:

  • TOP_MENU_MUSIC_ID

overlay1:

  • MAIN_MENU
  • SUBMENU
  • CONTINUE_CHOICE
  • MAIN_DEBUG_MENU_1
  • MAIN_DEBUG_MENU_2

overlay9:

  • TOP_MENU_RETURN_MUSIC_ID

overlay10:

  • BURN_DAMAGE_COOLDOWN
  • POISON_DAMAGE_COOLDOWN
  • BAD_POISON_DAMAGE_COOLDOWN
  • GINSENG_CHANCE_3
  • MUSIC_ID_TABLE
  • RANDOM_MUSIC_ID_TABLE
  • TILESET_PROPERTIES
  • FIXED_ROOM_MONSTER_SPAWN_STATS_TABLE
  • FIXED_ROOM_PROPERTIES_TABLE
  • LIFE_SEED_HP_BOOST
  • SITRUS_BERRY_HP_RESTORATION
  • ORAN_BERRY_HP_RESTORATION
  • INTIMIDATOR_ACTIVATION_CHANCE
  • SPAWN_COOLDOWN
  • SPAWN_COOLDOWN_THIEF_ALERT
  • TACTICS_UNLOCK_LEVEL_TABLE
  • TEXT_SPEED

overlay11:

  • GroundMainLoop
  • SsbLoad1
  • SsbLoad2
  • StationLoadHanger
  • ScriptStationLoadTalk
  • FuncThatCallsCommandParsing
  • ScriptCommandParsing
  • GROUND_STATE_MAP
  • GROUND_STATE_PTRS
  • UNIONALL_RAM_ADDRESS
  • LEVEL_TILEMAP_LIST
  • RECRUITMENT_TABLE_SPECIES
  • RECRUITMENT_TABLE_LEVELS
  • RECRUITMENT_TABLE_LOCATIONS

overlay11 extra (introduced via patch, definitions in skytemple-files):

  • MONSTER_GROUND_IDLE_ANIM

overlay13:

  • STARTERS_PARTNER_IDS
  • STARTERS_HERO_IDS
  • QUIZ_DEBUG_MENU

overlay14:

  • FOOTPRINT_DEBUG_MENU

overlay15:

  • BANK_MAIN_MENU

overlay16:

  • EVO_MENU_CONFIRM
  • EVO_SUBMENU
  • EVO_MAIN_MENU

overlay17:

  • ASSEMBLY_MENU_CONFIRM
  • ASSEMBLY_MAIN_MENU_1
  • ASSEMBLY_MAIN_MENU_2
  • ASSEMBLY_SUBMENU_1
  • ASSEMBLY_SUBMENU_2
  • ASSEMBLY_SUBMENU_3
  • ASSEMBLY_SUBMENU_4
  • ASSEMBLY_SUBMENU_5
  • ASSEMBLY_SUBMENU_6
  • ASSEMBLY_SUBMENU_7

overlay18:

  • MOVES_MENU_CONFIRM
  • MOVES_SUBMENU_1
  • MOVES_SUBMENU_2
  • MOVES_MAIN_MENU
  • MOVES_SUBMENU_3
  • MOVES_SUBMENU_4
  • MOVES_SUBMENU_5
  • MOVES_SUBMENU_6
  • MOVES_SUBMENU_7

overlay19:

  • BAR_MENU_CONFIRM_1
  • BAR_MENU_CONFIRM_2
  • BAR_MAIN_MENU
  • BAR_SUBMENU_1
  • BAR_SUBMENU_2

overlay20:

  • RECYCLE_MENU_CONFIRM_1
  • RECYCLE_MENU_CONFIRM_2
  • RECYCLE_SUBMENU_1
  • RECYCLE_SUBMENU_2
  • RECYCLE_MAIN_MENU_1
  • RECYCLE_MAIN_MENU_2
  • RECYCLE_MAIN_MENU_3

overlay21:

  • SWAP_SHOP_MENU_CONFIRM
  • SWAP_SHOP_SUBMENU_1
  • SWAP_SHOP_SUBMENU_2
  • SWAP_SHOP_MAIN_MENU_1
  • SWAP_SHOP_MAIN_MENU_2
  • SWAP_SHOP_SUBMENU_3

overlay22:

  • SHOP_MENU_CONFIRM
  • SHOP_MAIN_MENU_1
  • SHOP_MAIN_MENU_2
  • SHOP_MAIN_MENU_3

overlay23:

  • STORAGE_MENU_CONFIRM
  • STORAGE_MAIN_MENU_1
  • STORAGE_MAIN_MENU_2
  • STORAGE_MAIN_MENU_3
  • STORAGE_MAIN_MENU_4

overlay24:

  • DAYCARE_MENU_CONFIRM
  • DAYCARE_MAIN_MENU

overlay25:

  • APPRAISAL_MENU_CONFIRM
  • APPRAISAL_MAIN_MENU
  • APPRAISAL_SUBMENU

overlay27:

  • DISCARD_ITEMS_MENU_CONFIRM
  • DISCARD_ITEMS_SUBMENU_1
  • DISCARD_ITEMS_SUBMENU_2
  • DISCARD_ITEMS_MAIN_MENU

overlay29:

  • DUNGEON_PTR
  • BELLY_LOST_PER_TURN
  • BELLY_DRAIN_IN_WALLS_INT
  • BELLY_DRAIN_IN_WALLS_THOUSANDTHS
  • FIXED_ROOM_ENTITY_SPAWN_TABLE
  • FIXED_ROOM_ITEM_SPAWN_TABLE
  • FIXED_ROOM_MONSTER_SPAWN_TABLE
  • FIXED_ROOM_TILE_SPAWN_TABLE
  • FIXED_ROOM_REVISIT_OVERRIDES
  • NECTAR_IQ_BOOST

overlay31:

  • DUNGEON_MAIN_MENU
  • DUNGEON_SUBMENU_1
  • DUNGEON_SUBMENU_2
  • DUNGEON_SUBMENU_3
  • DUNGEON_SUBMENU_4
  • DUNGEON_SUBMENU_5
  • DUNGEON_SUBMENU_6

overlay34:

  • START_MENU_CONFIRM
  • DUNGEON_DEBUG_MENU
@theCapypara theCapypara added this to To do in Core: All open issues via automation May 20, 2022
@theCapypara theCapypara added this to Open in 1.4 via automation May 20, 2022
@theCapypara theCapypara removed this from Open in 1.4 Jul 25, 2022
@theCapypara
Copy link
Member Author

See also SkyTemple/skytemple#75

@theCapypara theCapypara added the help wanted Extra attention is needed label Jul 16, 2023
@theCapypara theCapypara mentioned this issue Aug 30, 2023
Merged
@Laioxy
Copy link

Laioxy commented Sep 2, 2023

DebugPrint0 in arm9 seems to already contain JP symbols, am I missing something?

https://github.com/UsernameFodder/pmdsky-debug/blob/af50b36fd34eb4be100d58f5ff56dddc335452ba/symbols/arm9.yml#L1011-L1021

@theCapypara
Copy link
Member Author

You are right! I probably didn't check correctly.

@Adex-8x Adex-8x mentioned this issue Sep 3, 2023
Merged
UsernameFodder pushed a commit to UsernameFodder/pmdsky-debug that referenced this issue Sep 3, 2023
@Adex-8x
Various JP symbols (ov18 - ov34) (#177)
0d73833 
Adds various JP symbols in some overlays (ranging from 18 to 34).
Related to SkyTemple/skytemple-files#235.
This was referenced Sep 4, 2023
Merged
Merged
UsernameFodder pushed a commit to UsernameFodder/pmdsky-debug that referenced this issue Sep 4, 2023
@Adex-8x
Various JP symbols (arm9, ov11 - ov17) (#179)
142413a 
Adds various JP symbols in arm9, ram, and some overlays.
Related to SkyTemple/skytemple-files#235.
@Adex-8x Adex-8x mentioned this issue Sep 4, 2023
Merged
@theCapypara
Copy link
Member Author

After https://github.com/UsernameFodder/pmdsky-debug/pull/180/files is merged we can then take the next release of pmdsky-debug-py (generated nightly) and close this.

Core: All open issues automation moved this from To do to Done Sep 4, 2023
UsernameFodder pushed a commit to UsernameFodder/pmdsky-debug that referenced this issue Sep 4, 2023
@Adex-8x
A bit of overlay01 symbols (#180)
7581347 
Adds some overlay01 JP symbols and should close SkyTemple/skytemple-files#235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed jp-support
Projects
1.6
Status: Done
Core: All open issues
  
Done
JP Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A bit of overlay01 JP symbols Adex-8x/pmdsky-debug
2 participants
@theCapypara @Laioxy