Add FixMemorySoftlock patch #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
marius851000
pushed a commit
to marius851000/skytemple-files
that referenced
this pull request
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a patch that can help prevent the crashes that happen when the game runs out of memory when displaying sprites in cutscenes (this has been observed in roms that had custom sprites or had used the randomizer). Other glitches could happen instead, but it will probably stop the softlock.
The patch has no effect in the normal behaviour of the game, as long as it doesn't run out of memory the patch will not trigger.
In the only test I've done so far, the game went from a softlock to running with no apparent side effects after applying the patch.