Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddTypes Matchup Error #576

Closed
Espik opened this issue Jul 16, 2023 · 4 comments
Closed

AddTypes Matchup Error #576

Espik opened this issue Jul 16, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@Espik
Copy link

Espik commented Jul 16, 2023

When the AddTypes patch is applied, Foresight, Scrappy, and other Exclusive Items do not change Normal and Fighting's type matchup against Ghost. The functionality with Miracle Eye is either unknown or untested.
@theCapypara theCapypara added the help wanted Extra attention is needed label Jul 29, 2023
@theCapypara
Copy link
Member

I need somebody with ASM knowledge to fix that.

@Espik
Copy link
Author

Espik commented Jul 29, 2023

I need somebody with ASM knowledge to fix that.

All that needs to change is replacing two "00"s with "02"s.

@theCapypara
Copy link
Member

Then I'm happy for a PR that changes it, because I don't know where.

@theCapypara
Copy link
Member

Fixed by Adex in SkyTemple/skytemple-files#431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
Core: All open issues
Status: Done
1.6
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theCapypara @Espik